Review Request: Add some feature to presence icon

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103802/#review10134
-----------------------------------------------------------

Ship it!


Looks good. Actually I needed an iconName method for some of Fernando's QML code, so this is fantastic :-D.


KTp/presence.h
<http://git.reviewboard.kde.org/r/103802/#comment8350>

    Add some documentation saying what you just said at the top of the review request.



KTp/presence.h
<http://git.reviewboard.kde.org/r/103802/#comment8351>

    I think iconName is a bit clearer. It's closer to matching QIcon::name();
    
    If you disagree, just stick with yours, I don't care that much.
    
    


- David Edmundson


On Jan. 27, 2012, 12:50 p.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103802/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2012, 12:50 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> The method "KIcon Presence::icon() const" becomes "KIcon Presence::icon(bool useImIcons = false) const" that allows you to use im-user-* icons instead of the user-* (i.e. the "pawn" icons instead of the "circles")
> Adds a method "KIcon Presence::icon(QStringList overlays, bool useImIcons = false) const" that allows to construct the icon with overlays.
> Finally adds a method "QString Presence::icon(bool useImIcons = false) const" to get the name of the icon for the current presence (useful if you want to create an icon using the presence as overlay)
> 
> 
> WARNING: This patch breaks the ABI (Not API though) and you will have to recompile the presence-applet or it will make plasma-desktop crash at next login if you have one in the taskbar (possibly also if you have it in the desktop)
> 
> 
> Diffs
> -----
> 
>   KTp/presence.h 07f3576e75b75cf76c038776e55f7c02a3cda395 
>   KTp/presence.cpp d291a812e1521b295a5c5d147b152140f5a17411 
> 
> Diff: http://git.reviewboard.kde.org/r/103802/diff/diff
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120127/87628aaa/attachment-0001.html>