Review Request: Make contact-info dialog modeless

[Dominik Cermak]

> On Jan. 27, 2012, 11:02 a.m., David Edmundson wrote:
> > context-menu.cpp, line 296
> > <http://git.reviewboard.kde.org/r/103801/diff/1/?file=48013#file48013line296>
> >
> >     surely you should check m_contactInfoDialog first.
> >     
> >     Otherwise you can spawn multiple versions of it, and under your current system the first one would leak.
> 
> Dominik Cermak wrote:
>     But if I use Qt::WA_DeleteOnClose it is ok to have multiple of them, cause all are deleted. So no need to change this. Right?
> 
> David Edmundson wrote:
>     In terms of leaking things. No.
>     If you want to avoid the UI issue(if it is one) of having multiple dialogs, probably.

I think the user should be able to open multiple of them if he wants to.
I asked alin about that:
<xerdomii> alin: what's your opinion: should it possible to have multiple contact-info dialogs open at the same time?
<alin> xerdomii: yes... 
<alin> xerdomii: it shall be possible... give the user the option to decide how tidy is

If it turns out to be a usability problem we can change it anyway.


- Dominik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103801/#review10124
-----------------------------------------------------------


On Jan. 27, 2012, 12:06 p.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103801/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2012, 12:06 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Make contact-info dialog modeless so it doesn't block.
> 
> 
> Diffs
> -----
> 
>   context-menu.h 48d0f9f 
>   context-menu.cpp b2cb7b2 
> 
> Diff: http://git.reviewboard.kde.org/r/103801/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120127/dc7ab50a/attachment.html>