Review Request: Add Connection Status to Global Presence

Dominik Cermak d.cermak at arcor.de
Thu Jan 19 19:06:41 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103739/#review9954
-----------------------------------------------------------

Ship it!


Ship it, only little typo.


KTp/global-presence.h
<http://git.reviewboard.kde.org/r/103739/#comment8221>

    Little typo: then connected if an account
    Maybe better: else connected if at least one account is connected


- Dominik Cermak


On Jan. 19, 2012, 5:56 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103739/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2012, 5:56 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Required for https://git.reviewboard.kde.org/r/103738/. Adds a global connection status. 
> 
> Edit: just removed my last blank line from the commit, so need to comment on that.
> 
> 
> Diffs
> -----
> 
>   KTp/global-presence.h 01706b0 
>   KTp/global-presence.cpp 4fe4407 
> 
> Diff: http://git.reviewboard.kde.org/r/103739/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120119/279568b8/attachment-0001.html>


More information about the KDE-Telepathy mailing list