Review Request: Use ConnectionStatus for Global PresenceSpinner

David Edmundson kde at davidedmundson.co.uk
Thu Jan 19 17:52:24 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103738/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Base the spinner in global presence off when an account is in ConnectionStatusConnecting rather changingPresence.
It turns out changingPresence is rubbish, some accounts just sit there with it constantly on if requested to go into a state they can't handle.

I'm not sure whether spinning each time you change presence was a good idea anyway. (it was mine)

This patch is related to a patch in common internals about to be uploaded. (add connection status to global presence)


Diffs
-----

  global-presence-chooser.h 2c4a0ec 
  global-presence-chooser.cpp 8ebfc1c 

Diff: http://git.reviewboard.kde.org/r/103738/diff/diff


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120119/b7a73254/attachment-0001.html>


More information about the KDE-Telepathy mailing list