Review Request: Add a property to GlobalPresence to set whether it can activate offline accounts.

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103709/#review9880
-----------------------------------------------------------

Ship it!


The code is ok to me, although I don't really understand its purpose, but I trust you on that as I'm likely to be missing the big picture.

- Dario Freddi


On Jan. 16, 2012, 5 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103709/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2012, 5 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add a property to GlobalPresence to set whether it can activate offline accounts.
>     
> This is for use in the kded which should never be trying to bring an offline account online. Should help deal with accounts that can't connect, and hopefully some progress on the infinite spinning wheel.
> 
> 
> Diffs
> -----
> 
>   KTp/global-presence.h 01706b0 
>   KTp/global-presence.cpp 4fe4407 
> 
> Diff: http://git.reviewboard.kde.org/r/103709/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120116/b59b4f7a/attachment.html>