Review Request: automagically install telepathy-gabble / -haze

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103637/#review9612
-----------------------------------------------------------



src/add-account-assistant.cpp
<http://git.reviewboard.kde.org/r/103637/#comment7884>

    Imho, this message should still mention what is missing. Not every distro uses packagekit...



src/add-account-assistant.cpp
<http://git.reviewboard.kde.org/r/103637/#comment7885>

    These names will work for debian-based distros (which are not using packagekit by default btw :P), but I don't think every distro uses these names...



src/add-account-assistant.cpp
<http://git.reviewboard.kde.org/r/103637/#comment7887>

    Maybe it would be better using the kde semantic tags instead...
    http://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics



src/add-account-assistant.cpp
<http://git.reviewboard.kde.org/r/103637/#comment7886>

    Hm, syncrhonous dbus calls... Do I assume right that this waits for packagekit to do the whole installation before it returns?


- George Kiagiadakis


On Jan. 6, 2012, 1 p.m., Florian Reinhard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103637/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2012, 1 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> automagically install telepathy-gabble / -haze.
> 
> needs kpackagekit installed. (not there by default for kubuntu, they patch stuff to use qapt).
> 
> We possibly want to add a cmake variable for the packagenames like kdenetwork does.
> 
> 
> Diffs
> -----
> 
>   src/add-account-assistant.cpp 3023cf9c63f8a2e5b32f88e4b633aa52680ca7c5 
> 
> Diff: http://git.reviewboard.kde.org/r/103637/diff/diff
> 
> 
> Testing
> -------
> 
> Purged telepathy-gabble, installation was triggered. 
> 
> 
> Thanks,
> 
> Florian Reinhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120106/331481d2/attachment.html>