Review Request: Add button in text-UI to load previous chat logs.
Martin Klapetek
martin.klapetek at gmail.com
Fri Feb 24 14:05:46 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104057/#review10870
-----------------------------------------------------------
Looks good, but part of the diff is malformed and therefore not displayed :/
Can you update it with correct diff?
logviewer/entity-model.h
<http://git.reviewboard.kde.org/r/104057/#comment8810>
This naming suits more to slots, not signals.
logviewer/entity-model.cpp
<http://git.reviewboard.kde.org/r/104057/#comment8811>
Whitespace
- Martin Klapetek
On Feb. 23, 2012, 11:39 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104057/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2012, 11:39 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Option in the text-ui to load previous chat logs.
>
> Adds optional toolbar item/menu entry in the text-ui
> Ktp-log-viewer reads command line args and auto-selects a user if account and contact ID are given.
>
>
> Diffs
> -----
>
> app/chat-window.h 4afa8a1
> app/chat-window.cpp 935b64b
> logviewer/entity-model.h cd6649e
> logviewer/entity-model.cpp a661d10
> logviewer/log-viewer.h 13a2504
> logviewer/log-viewer.cpp 3c664d9
> logviewer/main.cpp c783e73
>
> Diff: http://git.reviewboard.kde.org/r/104057/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120224/6b050d33/attachment.html>
More information about the KDE-Telepathy
mailing list