Review Request: Misc fixes in the Chat Plasmoid
Commit Hook
null at kde.org
Thu Feb 9 14:12:14 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103901/#review10457
-----------------------------------------------------------
This review has been submitted with commit f21b0ab2711b6416adb4c2d16ba58893b0ef6d19 by David Edmundson to branch master.
- Commit Hook
On Feb. 8, 2012, 11:18 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103901/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2012, 11:18 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Process messages in the plasmoid through our message
> targetContact() can be null, so check before trying to use it.
> Don't register to support group chats when we don't actually support them.
> Add a load of missing "consts"
>
>
> Diffs
> -----
>
> lib/message-processor.h 55f57e1
> lib/message.h cccf150
> plasmoid/declarative-plugin/conversation-target.h f2fee63
> plasmoid/declarative-plugin/conversation-target.cpp 1388613
> plasmoid/declarative-plugin/messages-model.h 4ae99d3
> plasmoid/declarative-plugin/messages-model.cpp 54d6949
> plasmoid/declarative-plugin/telepathy-text-observer.cpp 60ecd0d
>
> Diff: http://git.reviewboard.kde.org/r/103901/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120209/6a1f99a5/attachment.html>
More information about the KDE-Telepathy
mailing list