Review Request: Implement close button in plasmoid

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103879/#review10371
-----------------------------------------------------------

Ship it!


Nicely done. Two minor comments before merging.

Also your documentation could do with improving (existing), particularly on the header files of public methods. 


plasmoid/declarative-plugin/conversation.h
<http://git.reviewboard.kde.org/r/103879/#comment8538>

    slots shouldn't be a verb that sound like an action, it should be in past tense.
    
    It currently sounds like calling this will invalidate the channel, which is not the case.
    
    suggest "onInvalidated".



plasmoid/declarative-plugin/conversations-model.cpp
<http://git.reviewboard.kde.org/r/103879/#comment8539>

    Check this isn't -1. (which is returned when indexOf can't find anything)


- David Edmundson


On Feb. 6, 2012, 12:49 p.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103879/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2012, 12:49 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This makes ConversationsModel remove every conversation whose Tp::TextChannel becomes invalid. Since this plasmoid is primarily meant to allow for quick response for incomming chats, I don't think closed channels have any place here.
> 
> The close button calls requestClose in the text channel so it'll be closed and removed from the plasmoid.
> 
> 
> This addresses bug 292974.
>     http://bugs.kde.org/show_bug.cgi?id=292974
> 
> 
> Diffs
> -----
> 
>   plasmoid/declarative-plugin/conversation.h a072a51 
>   plasmoid/declarative-plugin/conversation.cpp 89cd4e8 
>   plasmoid/declarative-plugin/conversations-model.h 6d38c3d 
>   plasmoid/declarative-plugin/conversations-model.cpp ad13f67 
>   plasmoid/declarative-plugin/messages-model.h 8da3626 
>   plasmoid/declarative-plugin/messages-model.cpp 3b4d4db 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml 4de2ef3 
> 
> Diff: http://git.reviewboard.kde.org/r/103879/diff/diff
> 
> 
> Testing
> -------
> 
> Opened a bunch of chats, then closed them.
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120206/52200fdb/attachment-0001.html>