Review Request: MessageProcessor and Filters
Lasath Fernando
kde at lasath.org
Fri Feb 3 12:37:50 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103848/
-----------------------------------------------------------
(Updated Feb. 3, 2012, 12:37 p.m.)
Review request for Telepathy and David Edmundson.
Changes
-------
Addressed most issues in review.
Description
-------
Create an extensible framework for dealing with incomming messages in text-ui. This patch implements a MessageProcessor and 3 MessageFilters: Url and emoticon parsers, as well as an image embedding plugin (for funsizes :).
Eventually these will be turned into actual plugins that are loaded at runtime rather than being hardcoded. But for now, they just make David's code cleaner.
Diffs (updated)
-----
lib/CMakeLists.txt 31dadd2
lib/adium-theme-message-info.cpp c5e0dfc
lib/adium-theme-view.h be90d65
lib/adium-theme-view.cpp a0e7ac1
lib/chat-widget.cpp 75acef0
lib/emoticon-filter.cpp PRE-CREATION
lib/escape-filter.cpp PRE-CREATION
lib/filters.h PRE-CREATION
lib/image-filter.cpp PRE-CREATION
lib/message-processor.h PRE-CREATION
lib/message-processor.cpp PRE-CREATION
lib/message.h PRE-CREATION
lib/message.cpp PRE-CREATION
lib/url-filter.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/103848/diff/diff
Testing
-------
Spammed meme images at david. He seemed to be happy and replied with lots of smiley faces.
Thanks,
Lasath Fernando
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120203/2220cdc0/attachment.html>
More information about the KDE-Telepathy
mailing list