Review Request: MessageProcessor and Filters

[Lasath Fernando]

> On Feb. 2, 2012, 3:01 p.m., David Edmundson wrote:
> > lib/filters.h, line 33
> > <http://git.reviewboard.kde.org/r/103848/diff/1/?file=48495#file48495line33>
> >
> >     Defined, but never declared.

oops, forgot to git add it


> On Feb. 2, 2012, 3:01 p.m., David Edmundson wrote:
> > lib/image-filter.cpp, line 37
> > <http://git.reviewboard.kde.org/r/103848/diff/1/?file=48496#file48496line37>
> >
> >     break? What if there's two images?

http://local.lasath.org/image_thing2.png

It doesn't break the second for loop.


> On Feb. 2, 2012, 3:01 p.m., David Edmundson wrote:
> > lib/message.cpp, line 67
> > <http://git.reviewboard.kde.org/r/103848/diff/1/?file=48500#file48500line67>
> >
> >     What was the motivation behind changing this from QString to const char*.
> >     
> >     (not saying it's wrong, I just want the reasoning)

Was a pain in the ass to QLatinString() each time I wanted to use "Urls". 

Also, I want to define a literal constant rather than typing "Urls", but I don't know how they're done according to KDE code policy. (at uni we'd use a #define)


> On Feb. 2, 2012, 3:01 p.m., David Edmundson wrote:
> > lib/message.h, line 39
> > <http://git.reviewboard.kde.org/r/103848/diff/1/?file=48499#file48499line39>
> >
> >     This should probably be inside Message::Private, which I'm starting to think should be a QSharedData.

I just gave it a d-pointer. But why a QSharedData?


- Lasath


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103848/#review10284
-----------------------------------------------------------


On Feb. 2, 2012, 2:42 p.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103848/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2012, 2:42 p.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Create an extensible framework for dealing with incomming messages in text-ui. This patch implements a MessageProcessor and 3 MessageFilters: Url and emoticon parsers, as well as an image embedding plugin (for funsizes :).
> Eventually these will be turned into actual plugins that are loaded at runtime rather than being hardcoded. But for now, they just make David's code cleaner.
> 
> 
> Diffs
> -----
> 
>   lib/CMakeLists.txt 31dadd2 
>   lib/adium-theme-message-info.cpp c5e0dfc 
>   lib/adium-theme-view.cpp a0e7ac1 
>   lib/chat-widget.cpp 75acef0 
>   lib/filters.h PRE-CREATION 
>   lib/image-filter.cpp PRE-CREATION 
>   lib/message-processor.h PRE-CREATION 
>   lib/message-processor.cpp PRE-CREATION 
>   lib/message.h PRE-CREATION 
>   lib/message.cpp PRE-CREATION 
>   lib/url-filter.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103848/diff/diff
> 
> 
> Testing
> -------
> 
> Spammed meme images at david. He seemed to be happy and replied with lots of smiley faces.
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120203/b8a01f19/attachment.html>