Review Request: Refactor AccountFilterModel and add a class ContactGridWidget (mostly imported from ktp-send-file)

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Thu Feb 2 21:15:26 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103702/
-----------------------------------------------------------

(Updated Feb. 2, 2012, 9:15 p.m.)


Review request for Telepathy and David Edmundson.


Changes
-------

- Refactor AccountFilterModel (this will break contact list and some other repositories, I will fix them after this is pushed)
- Use icon size from style options in delegate
- Update the class according to the changes in AccountFilterModel
- Expose the AccountFilterModel instead of adding methods


Summary (updated)
-----------------

Refactor AccountFilterModel and add a class ContactGridWidget (mostly imported from ktp-send-file)


Description
-------

This patch adds a class ContactGridWidget to the common module.
The class is basically the widget used in ktp-send-file for displaying the contacts (grid view + filter bar)

I had to add a new directory "Widgets" and a new library, because the class depends both on the "common" and the "models" modules.


Diffs (updated)
-----

  KTp/CMakeLists.txt f17ff8c3bb54408d3bfaf7773bae0e736836b9b2 
  KTp/Models/CMakeLists.txt ce628732c3b82a02803837dd8a720b5f11281945 
  KTp/Models/accounts-filter-model.h 36f8288b0edcbd4f809b860cf54ab19dfe5ffddf 
  KTp/Models/accounts-filter-model.cpp 859c6735ee2f70ea1ba5b3ace1e4d0e788b10c13 
  KTp/Models/accounts-model.h c86d8cfafad1e956f98f9111b54e8cb923926c98 
  KTp/Models/accounts-model.cpp 13aaa4cb1e9f9a49ee40191163809795a96fc611 
  KTp/Models/contact-model-item.h 2bb845c90a0c5ce7d494758bed01b13972432313 
  KTp/Models/flat-model-proxy.h PRE-CREATION 
  KTp/Models/flat-model-proxy.cpp PRE-CREATION 
  KTp/Widgets/CMakeLists.txt PRE-CREATION 
  KTp/Widgets/contact-grid-widget.h PRE-CREATION 
  KTp/Widgets/contact-grid-widget.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/103702/diff/diff


Testing
-------

Succesfully used in the unreleased telepathy kipi plugin


Thanks,

Daniele Elmo Domenichelli

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120202/3f82f515/attachment.html>


More information about the KDE-Telepathy mailing list