[Bug 293067] Plasma crashes on opening a chat from contact list

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=293067


David Edmundson <kde at davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kde at davidedmundson.co.uk




--- Comment #1 from David Edmundson <kde davidedmundson co uk>  2012-02-01 18:36:00 ---
The weird thing is, that I removed the chat plasmoid from my panel few hours
ago. Now when I started chat with someone who was in the plasmoid, plasma went
down.

I think that's actually key to this.

If this plasmoid is started, you'll create all the telepathy objects
I think ConversationClientObserver is "leaked", as the observer hold a
reference to the clientRegistrar which holds a refernece ot the observer.

So when you close the plasmoid these both stick around. When you delete the
plasmoid TelepathyTextObserver is null, and the
ConversationClientObserver::m_parent is now a dead pointer.

Fixes needed:
 1) fix the circular dependency in the ConversationClientObserver (move
registrar to TelepathyTextObserver)
 2) use a QWeakPointer on m_parent (and check before using)
 3) rename one of these classes so it's not really really confusing.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.