Review Request: add easy to add emoticons to ktp-text-ui

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108040/#review24297
-----------------------------------------------------------

Ship it!


Just some coding-style nitpicks. Fix them and commit.


app/chat-window.cpp
<http://git.reviewboard.kde.org/r/108040/#comment18596>

    Remove the whitespace



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/108040/#comment18597>

    Put '{' on a new line



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/108040/#comment18598>

    Spaces around the '=' operator



app/chatwindow.rc
<http://git.reviewboard.kde.org/r/108040/#comment18595>

    Remove the Whitespace



lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/108040/#comment18593>

    Put '{' on a new line



lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/108040/#comment18594>

    Spaces around the '+' operator


- Dan Vrátil


On Dec. 30, 2012, 10:50 p.m., Alin M Elena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108040/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2012, 10:50 p.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> add a toolbar that makes easier to add the emoticons from the kde theme...
> 
> 
> This addresses bug 302005.
>     http://bugs.kde.org/show_bug.cgi?id=302005
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3057b3c 
>   app/CMakeLists.txt 3050e95 
>   app/chat-window.h 759942f 
>   app/chat-window.cpp 6567e91 
>   app/chatwindow.rc 29f7c17 
>   lib/chat-widget.h a103a9b 
>   lib/chat-widget.cpp 568b7e2 
> 
> Diff: http://git.reviewboard.kde.org/r/108040/diff/
> 
> 
> Testing
> -------
> 
> I have played around with the emoticons and they act as expected.
> 
> 
> Screenshots
> -----------
> 
> emoticons
>   http://git.reviewboard.kde.org/r/108040/s/943/
> 
> 
> Thanks,
> 
> Alin M Elena
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121230/ae18f77c/attachment.html>