Review Request: Some bugfixes in model_refactor_2 branch

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108018/
-----------------------------------------------------------

Review request for Telepathy and David Edmundson.


Description
-------

AccountsTreeProxyModel
 - remove debugging messages (looks useless to me)

ContactsFilterModel
 - make OnlineUsersCountRole and TotalUsersCountRole work with ContactsListModel as source model. Did not test with ContactsModel, but it should now work with both of them (essentially I had to port the code away from GroupsModelItem and AccountsModelItem since these are ContactsModel-specific).

ContactsListModel
 - emit changed() when contact's group membership changes


Diffs
-----

  KTp/Models/abstract-grouping-proxy-model.cpp 533d545 
  KTp/Models/accounts-tree-proxy-model.h 98bab16 
  KTp/Models/accounts-tree-proxy-model.cpp e5ad725 
  KTp/Models/contacts-filter-model.cpp 269505c 
  KTp/Models/contacts-list-model.cpp 219ee5f 

Diff: http://git.reviewboard.kde.org/r/108018/diff/


Testing
-------

ContactsFilterModel
 - online/total contacts counts are correctly displayed with both grouping types

ContactsListModel
 - moving contact to a different group updates the model as expected


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121230/5fa946ef/attachment.html>