Review Request: Add option to set how many lines of history should be loaded in chat

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107968/#review24097
-----------------------------------------------------------


This review has been submitted with commit 55eb12c86b2b5ea12682378bf3cd6b29e6fe64e1 by Dan Vrátil to branch master.

- Commit Hook


On Dec. 28, 2012, 2:10 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107968/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2012, 2:10 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Adds a QSpinBox to "Chat Tab Behavior" tab to set how many lines of previous conversation should be loaded when opening a new chat.
> 
> The default amount is 4, available range is 0 - 100. I think that this is better then "Last hour", "Last 24 hours" etc as Daniele suggested in the bug report because "Last 24 hours" can result in no message or 1000 messages being loaded.
> 
> It also fixes the LogManager to return m_fetchAmount instead of m_fetchAmount + 1 messages :)
> 
> 
> This addresses bug 310982.
>     http://bugs.kde.org/show_bug.cgi?id=310982
> 
> 
> Diffs
> -----
> 
>   config/behavior-config.h 55d2fea 
>   config/behavior-config.cpp 6e78168 
>   config/behavior-config.ui 7b8e304 
>   lib/chat-widget.cpp 8f63e14 
>   lib/logmanager.cpp 50d1622 
> 
> Diff: http://git.reviewboard.kde.org/r/107968/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121228/afcaec0f/attachment.html>