Review Request: Add action to clear chat view

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107967/#review24089
-----------------------------------------------------------

Ship it!


I want some changes listed below.
You can push for re-review afterwards if you like, or just ship it.


lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/107967/#comment18370>

    This is a bit of a blatant hack.
    Not helped that the original code is already pretty bad.
    
    At the very least change it to:
    
    d->logsLoaded
    
    and therefore 
    
    if (!d->logsLoaded) 
      d->logManag...
    }
    d->logsLoaded = true;
    
    that way we don't need to have something set the boolean to true anywhere, and it makes a bit more logical sense to someone reading the code.



lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/107967/#comment18371>

    I don't like disconnecting only to connect again.
    
    Either:
     - move the connect outside this method
     - use Qt::UniqueConnection 


- David Edmundson


On Dec. 28, 2012, 1:31 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107967/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2012, 1:31 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Adds "Edit"->"Clear View" action into ktp-text-ui. When triggered the AdiumThemeView is cleared and re-initialized but no messages from logs are loaded.
> 
> 
> This addresses bug 298319.
>     http://bugs.kde.org/show_bug.cgi?id=298319
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h a722105 
>   app/chat-window.cpp 0423d70 
>   app/chatwindow.rc 6e8c002 
>   lib/chat-widget.h 30a24e0 
>   lib/chat-widget.cpp 8f63e14 
> 
> Diff: http://git.reviewboard.kde.org/r/107967/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121228/f3d51c26/attachment-0001.html>