Review Request: Chat plasmoid fixes (global shortcut, visible property)

[Lasath Fernando]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107833/
-----------------------------------------------------------

(Updated Dec. 22, 2012, 9:12 a.m.)


Review request for Telepathy, David Edmundson and Aleix Pol Gonzalez.


Changes
-------

Fix a silly mistake caught by the non-2am me.


Description
-------

This does a few little fixes to the chat plasmoid getting it closer to being keyboard friendly. 

1. I redid the implementation of ConversationQueManager using a K_GLOBAL_STATIC it's now significantly shorter and more elegant IMHO.
2. I ditched the KAction with a hardcoded shortcut, and instead exposed ConversationQueManager to QML. So that way, the plasmoid can easily invoke dequeueNext() on plasmoid 'activate' shortcut. 

3. I fixed the massive klugde that was the visible property of the Dialog. Now, everything is encased in separate Item, which contains one property: isOpen. It isn't bound to anything - instead, there are methods to change its value. This ceases the infinite binding loop, and allows for a clearer logic. 
I.e. when button is clicked, dialog is closed with ALT+F4 or the model requestsPopout, those methods are called, which update 'isOpen' which in turn propagates the changes to Dialog.visible, ConversationDeleagte.checked and MessagesModel.visibleToUser properties as they are bound to it.

PS: Sorry if that wall of text didn't make any sense - It's difficult to think straight at 2AM :-)


This addresses bug 296929.
    http://bugs.kde.org/show_bug.cgi?id=296929


Diffs (updated)
-----

  plasmoid/declarative-plugin/conversation-que-manager.h e8ab426 
  plasmoid/declarative-plugin/conversation-que-manager.cpp a7b347a 
  plasmoid/declarative-plugin/messages-model.h 233bbfb 
  plasmoid/declarative-plugin/qml-plugins.cpp 23a4291 
  plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegate.qml 8a8d851 
  plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml feb766b 

Diff: http://git.reviewboard.kde.org/r/107833/diff/


Testing
-------

Talked to myself. Unfortunately, I didn't talk to multiple people at once though - hopefully everything should still work.


Thanks,

Lasath Fernando

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121222/9135b3cc/attachment.html>