Review Request: Add a ContactFactory and Contact class allowing the subclassing of Tp::Contact

David Edmundson david at davidedmundson.co.uk
Wed Dec 19 16:19:16 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107629/
-----------------------------------------------------------

(Updated Dec. 19, 2012, 4:19 p.m.)


Review request for Telepathy.


Changes
-------

Make a new ContactsListModel. Which will form the basis of the basis of all the new contact models.
Based on KTp::Contact.


Description (updated)
-------

- Add a new list model of Contacts
- Add a ContactFactory and Contact class allowing the subclassing of Tp::Contact
- Move capabilities hack outside of models so it can be used by future KTp::Contact


Diffs (updated)
-----

  KTp/CMakeLists.txt 64a12b22b5125d1ba44a3e82af20c8d3d7dccd73 
  KTp/Models/CMakeLists.txt 404eee32735489a80c6e93e5f90b1db549536386 
  KTp/Models/accounts-filter-model.cpp dd911ac294dd8aeaa7e2e1d6f8bc11665121d1ec 
  KTp/Models/capabilities-hack-private.h aa3478faadceb55450cc9e6725c407095f8e3f94 
  KTp/Models/capabilities-hack-private.cpp 46ba34e38bc4f4743beb032bf01992be952aaeef 
  KTp/Models/contacts-list-model.h PRE-CREATION 
  KTp/Models/contacts-list-model.cpp PRE-CREATION 
  KTp/capabilities-hack-private.h PRE-CREATION 
  KTp/capabilities-hack-private.cpp PRE-CREATION 
  KTp/contact-factory.h PRE-CREATION 
  KTp/contact-factory.cpp PRE-CREATION 
  KTp/contact.h PRE-CREATION 
  KTp/contact.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/107629/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121219/b5020e8c/attachment.html>


More information about the KDE-Telepathy mailing list