Review Request: Fix the "Join Chat Room" dialog

Dan Vrátil dvratil at redhat.com
Mon Dec 17 00:04:11 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107774/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

While testing the nick completion I noticed that remove/clear buttons in "Favorites" and "Recent" tabs in "Join Chat Room" don't work. 

The code was using an incorrect method to retrieve account unique identifier, probably a leftover form before AccountsComboBox port :)


Diffs
-----

  KTp/Widgets/join-chat-room-dialog.cpp c29c3e8 

Diff: http://git.reviewboard.kde.org/r/107774/diff/


Testing
-------

Removing rooms from Favorites/Recent tabs works.


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121217/91e011c5/attachment.html>


More information about the KDE-Telepathy mailing list