Review Request: Look async'sly for mpris2 dbus interfaces

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107605/#review23053
-----------------------------------------------------------

Ship it!


There's also the issue that we're calling this multiple times, and this should be only be done on startup.
The rest can be tracked in the serviceOwnerChanged()

Push to 0.5 too.

- David Edmundson


On Dec. 6, 2012, 1:19 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107605/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2012, 1:19 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> QDBusConnection::sessionBus().interface()->registeredServiceNames() is sync dbus call, freezing some things while being called. This does that call in async way.
> 
> 
> This addresses bug 310826.
>     http://bugs.kde.org/show_bug.cgi?id=310826
> 
> 
> Diffs
> -----
> 
>   telepathy-mpris.h 9937139 
>   telepathy-mpris.cpp 71b0d24 
> 
> Diff: http://git.reviewboard.kde.org/r/107605/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121206/084daf42/attachment.html>