Review Request: Add plasma-themeability to the menu on the presence applet

Commit Hook null at kde.org
Wed Dec 5 03:50:10 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107545/#review23007
-----------------------------------------------------------


This review has been submitted with commit bd830ee22b42aed26342d63729ac97d5f9d69a99 by Peter Amidon to branch master.

- Commit Hook


On Dec. 1, 2012, 5:39 p.m., Andromeda Galaxy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107545/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2012, 5:39 p.m.)
> 
> 
> Review request for Telepathy and KDE Usability.
> 
> 
> Description
> -------
> 
> The Presence applet will show a Plasma-themed icon on the desktop now. However, the menu items for statuses are still all Oxygen, so the user experience is inconsistent -- if the user clicks on an icon for status, they won't get that icon on the toolbar. The attached diff, if applied to the master, will make it so that those menu items are also Plasma-themed.
> 
> 
> Diffs
> -----
> 
>   src/presenceapplet.h 78ccfbd 
>   src/presenceapplet.cpp 291cde4 
> 
> Diff: http://git.reviewboard.kde.org/r/107545/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> The plasma-themed applet
>   http://git.reviewboard.kde.org/r/107545/s/863/
> The presence dropdown on the contact list
>   http://git.reviewboard.kde.org/r/107545/s/864/
> 
> 
> Thanks,
> 
> Andromeda Galaxy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121205/8c16aa1d/attachment.html>


More information about the KDE-Telepathy mailing list