Review Request: Demo chat for Telepathy has been rewritten

[Maxime Corteel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107547/#review22930
-----------------------------------------------------------


Just a few comment about language (just improvements, I'm not sure if the demo chat should contain Oxford English sentences...).


config/appearance-config.cpp
<http://git.reviewboard.kde.org/r/107547/#comment17521>

    I guess you mean "I want to contribute _to_ Telepathy"



config/appearance-config.cpp
<http://git.reviewboard.kde.org/r/107547/#comment17523>

    You mean "its" sources. "It's" means "It is".
    And I think it would be better to write "Where can I get the sources?" or "Where can I get the source code" (but that's just my opinion).



config/appearance-config.cpp
<http://git.reviewboard.kde.org/r/107547/#comment17524>

    diff => a|the|your diff
    imporved => improved
    I'm also not sure about writing "P.S." in a text chat... Maybe replace it by "By the way, you should..."



config/appearance-config.cpp
<http://git.reviewboard.kde.org/r/107547/#comment17525>

    I don't know about this line in general, but to follow Dan's rule of no lazy English (which makes sense), I'd recommend "See you later" instead of "cya".
    Anyway, to keep the spirit of the sentence, I'd write something like "Sorry, I have to go now, I have a date with my girlfriend. See you later!". It's sad if you _need_ to visit your girlfriend...


- Maxime Corteel


On Dec. 1, 2012, 6:21 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107547/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2012, 6:21 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> I have rewritten the demo for chat for Telepathy.
> 
> 
> Diffs
> -----
> 
>   config/appearance-config.cpp a88dd02 
> 
> Diff: http://git.reviewboard.kde.org/r/107547/diff/
> 
> 
> Testing
> -------
> 
> Were successfully built.
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121203/1b4c7858/attachment.html>