Review Request: Add plasma-themeability to the menu on the presence applet
Andromeda Galaxy
peter at picnicpark.org
Sat Dec 1 16:59:52 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107545/
-----------------------------------------------------------
(Updated Dec. 1, 2012, 4:59 p.m.)
Review request for Telepathy.
Changes
-------
Fixed last issue in review comment.
Description
-------
The Presence applet will show a Plasma-themed icon on the desktop now. However, the menu items for statuses are still all Oxygen, so the user experience is inconsistent -- if the user clicks on an icon for status, they won't get that icon on the toolbar. The attached diff, if applied to the master, will make it so that those menu items are also Plasma-themed.
Diffs (updated)
-----
src/presenceapplet.h 78ccfbd
src/presenceapplet.cpp 291cde4
Diff: http://git.reviewboard.kde.org/r/107545/diff/
Testing
-------
Screenshots
-----------
The plasma-themed applet
http://git.reviewboard.kde.org/r/107545/s/863/
Thanks,
Andromeda Galaxy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121201/e907ec15/attachment-0001.html>
More information about the KDE-Telepathy
mailing list