Review Request: Add plasma-themeability to the menu on the presence applet

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107545/#review22879
-----------------------------------------------------------


I'm wondering about the looks. We now have 2 inconsistent presence menus - one here and one in contact list; both iconsets are different. I'm not sure that's a good idea. But then again - the icon in the systray is already different.

Andromeda, please add "usability" group in the reviewers, thanks.

- Martin Klapetek


On Dec. 1, 2012, 4:59 p.m., Andromeda Galaxy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107545/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2012, 4:59 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> The Presence applet will show a Plasma-themed icon on the desktop now. However, the menu items for statuses are still all Oxygen, so the user experience is inconsistent -- if the user clicks on an icon for status, they won't get that icon on the toolbar. The attached diff, if applied to the master, will make it so that those menu items are also Plasma-themed.
> 
> 
> Diffs
> -----
> 
>   src/presenceapplet.h 78ccfbd 
>   src/presenceapplet.cpp 291cde4 
> 
> Diff: http://git.reviewboard.kde.org/r/107545/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> The plasma-themed applet
>   http://git.reviewboard.kde.org/r/107545/s/863/
> 
> 
> Thanks,
> 
> Andromeda Galaxy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121201/ad00ab4c/attachment.html>