Review Request: Fix formatting plugin

[David Edmundson]

> On Aug. 29, 2012, 6:41 a.m., Daniele Elmo Domenichelli wrote:
> > tests/message-processor-basic-tests.cpp, line 205
> > <http://git.reviewboard.kde.org/r/106005/diff/2/?file=81990#file81990line205>
> >
> >     I changed them because imho you should be able to copy and paste from the chat ui even if someone sends me stuff that gets formatted (i.e. "while (true /*this is a comment*/ )") should be formatted, but copied and pasted exactly as if it was plain text... (Thunderbird does that, but again I don't know what GTalk does)

relevant: http://lxr.kde.org/source/kde/kdepimlibs/kpimutils/linklocator.cpp#56 ?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106005/#review18204
-----------------------------------------------------------


On Aug. 28, 2012, 3:43 p.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106005/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2012, 3:43 p.m.)
> 
> 
> Review request for Telepathy, David Edmundson and Lasath Fernando.
> 
> 
> Description
> -------
> 
> Handle '_' as underlined and '/' as italics, fix the regexp and replacement string and re-enable the formatting plugin
> 
> 
> Diffs
> -----
> 
>   tests/message-processor-basic-tests.cpp a404908152ef9e21eb7e98cb472775f78c8a4162 
>   filters/CMakeLists.txt ee7c23d612cbc737271798344b1939052e1b7326 
>   filters/formatting/format-filter.h 4980aff8251a91b2e23de2a7d8257ed25b5d1322 
>   filters/formatting/format-filter.cpp 75157fa4b7cd70ad0a1bfdfe7fc8886c37a75ba1 
>   tests/message-processor-basic-tests.h 5ffcc92864820d9fd8c535cd4e249cb31310011b 
> 
> Diff: http://git.reviewboard.kde.org/r/106005/diff/
> 
> 
> Testing
> -------
> 
> Unit tests included and a few more visual test
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120831/e0bdbdea/attachment.html>