Review Request: Make ktp-text-ui use the link parser from common-internals

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106261/#review18222
-----------------------------------------------------------


This review has been submitted with commit 0ffe76e12bb7cc6473346d7f0acce69ebd74be2a by Rohan Garg to branch kde-telepathy-0.5.

- Commit Hook


On Aug. 29, 2012, 2:37 a.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106261/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2012, 2:37 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Make ktp-text-ui use link parser from common-internals.
> While this does not address bug 305725 directly, it's better to use the common internals regex parser and make changes in the common internals parser to detect urls like xkcd.com
> 
> 
> This addresses bug 305725.
>     http://bugs.kde.org/show_bug.cgi?id=305725
> 
> 
> Diffs
> -----
> 
>   lib/CMakeLists.txt 1aa830b 
>   lib/url-filter.cpp 3c86ad0 
> 
> Diff: http://git.reviewboard.kde.org/r/106261/diff/
> 
> 
> Testing
> -------
> 
> Had a nice chat with David where we discussed about what urls should be displayed and which ones should not.
> Here are a couple of urls I tested with : 
> http://www.amazon.com/Kindle-Wireless-Reading-Display-Globally/dp/B003FSUDM4/ref=amb_link_353259562_2?pf_rd_m=ATVPDKIKX0DER&pf_rd_s=center-10&pf_rd_r=11EYKTN682A79T370AM3&pf_rd_t=201&pf_rd_p=1270985982&pf_rd_i=B002Y27P3M
> 
> http://www.google.co.in/url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&ved=0CCUQIDAA&url=http%3A%2F%2Fwebcache.googleusercontent.com%2Fsearch%3Fq%3Dcache%3AR0Yg4I7xz-QJ%3Apaste.kde.org%2F%2B%26cd%3D1%26hl%3Den%26ct%3Dclnk%26gl%3Din&ei=K349UMT4NoLOrQe3ooCoBw&usg=AFQjCNHaq8YelpyyPOrr22vKy5FfZnTEnA&sig2=3gx5a6PrY1wXSjwRqx6ljg
> 
> ftp://ftp.kde.org/
> 
> irc://foo
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120829/bfe1a9da/attachment.html>