Review Request: [logviewer] Fix crash when Tpl::SearchHit has null account or entity

Dan Vratil dan at progdan.cz
Sat Aug 25 12:34:50 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106176/
-----------------------------------------------------------

Review request for Telepathy and Martin Klapetek.


Description
-------

For some reason (which is not quite clear to me) Tpl::SearchHit can have null account or entity. It might be worth finding out why it happens, but for now let's just make logviewer not to crash when such situation occurs.


This addresses bug 305750.
    http://bugs.kde.org/show_bug.cgi?id=305750


Diffs
-----

  logviewer/entity-proxy-model.cpp 5365783 

Diff: http://git.reviewboard.kde.org/r/106176/diff/


Testing
-------

Martin, could you please test it? I was unable to reproduce the crash you described in the bug even without this patch.


Thanks,

Dan Vratil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120825/9aeab6d9/attachment.html>


More information about the KDE-Telepathy mailing list