Review Request: Implemented the ObjectManager Interface and tabbed kwhiteboard

Mon Aug 20 19:05:05 UTC 2012

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106089/#review17770
-----------------------------------------------------------

kwhiteboard/kwhiteboard.cpp
<http://git.reviewboard.kde.org/r/106089/#comment13959>

    This should not be created by the whiteboard, but where the dbus connection is created.
    Instead of using m_objectManager you should add a static method

kwhiteboard/kwhiteboard.cpp
<http://git.reviewboard.kde.org/r/106089/#comment13956>

    Signatures are not normalised

kwhiteboard/kwhiteboardwidget.cpp
<http://git.reviewboard.kde.org/r/106089/#comment13957>

    Remove this

kwhiteboard/objectManager.h
<http://git.reviewboard.kde.org/r/106089/#comment13963>

    Do not use online for methods that are supposed to be in a library.

kwhiteboard/objectManager.h
<http://git.reviewboard.kde.org/r/106089/#comment13968>

    Why this constructor?

kwhiteboard/objectManager.h
<http://git.reviewboard.kde.org/r/106089/#comment13966>

    this should not be with the public Q_SLOTS

kwhiteboard/objectManager.h
<http://git.reviewboard.kde.org/r/106089/#comment13961>

    Those should be in the .cpp, not in the .h

kwhiteboard/objectManager.cpp
<http://git.reviewboard.kde.org/r/106089/#comment13958>

    alignment

Where is the part to unregister the objects and the handling of closed tabs?

- Daniele Elmo Domenichelli

On Aug. 20, 2012, 6:46 p.m., Puneet Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106089/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2012, 6:46 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Implemented the Object Manager Interface. Using the interface, Tabbed Kwhiteboard is also implemented.
> GetManagedObjects method of the interface is not implemented yet, and the interface added signal is also having a parameter of QString only.
> 
> 
> Diffs
> -----
> 
>   kwhiteboard/CMakeLists.txt 3bbea3c 
>   kwhiteboard/kwhiteboard.h 43b572a 
>   kwhiteboard/kwhiteboard.cpp deb7129 
>   kwhiteboard/kwhiteboardwidget.h 431ccf2 
>   kwhiteboard/kwhiteboardwidget.cpp ce1b2a9 
>   kwhiteboard/main.cpp aae48c7 
>   kwhiteboard/objectManager.h PRE-CREATION 
>   kwhiteboard/objectManager.cpp PRE-CREATION 
>   kwhiteboard/org.freedesktop.DBus.ObjectManager.xml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106089/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Puneet Goyal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120820/63e0988b/attachment-0001.html>