Review Request: Implemented the ObjectManager Interface and tabbed kwhiteboard

Mon Aug 20 12:32:46 UTC 2012

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106089/#review17750
-----------------------------------------------------------

kwhiteboard/kwhiteboard.h
<http://git.reviewboard.kde.org/r/106089/#comment13927>

    name of the variable is missing here

kwhiteboard/kwhiteboard.cpp
<http://git.reviewboard.kde.org/r/106089/#comment13929>

    You are translating an object path... this does not make sense

kwhiteboard/kwhiteboard.cpp
<http://git.reviewboard.kde.org/r/106089/#comment13930>

    Translating an object path does not make sense

kwhiteboard/kwhiteboardwidget.h
<http://git.reviewboard.kde.org/r/106089/#comment13934>

    No

kwhiteboard/kwhiteboardwidget.h
<http://git.reviewboard.kde.org/r/106089/#comment13931>

    parent must stay a QWidget and the addTab must be called directly by the parent class

kwhiteboard/kwhiteboardwidget.h
<http://git.reviewboard.kde.org/r/106089/#comment13933>

    This signal must not be in the KWhiteboardWidget

kwhiteboard/kwhiteboardwidget.cpp
<http://git.reviewboard.kde.org/r/106089/#comment13932>

    What is this??
    I have no idea of what are you doing here, but the object path that you pass to the widget must be already the correct one

kwhiteboard/objectManager.h
<http://git.reviewboard.kde.org/r/106089/#comment13926>

    names of the variables are missing here

kwhiteboard/objectManager.h
<http://git.reviewboard.kde.org/r/106089/#comment13925>

    names of the variables are missing here

kwhiteboard/objectManager.cpp
<http://git.reviewboard.kde.org/r/106089/#comment13928>

    Who should implement it?

I want to review ONLY YOUR PATCH, I don't want to review random unrelated changes, please in the next version remove all the comments to methods that are completely unrelated?
This doesn't mean that they are wrong, but they belong to another patch...

- Daniele Elmo Domenichelli

On Aug. 20, 2012, 12:03 p.m., Puneet Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106089/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2012, 12:03 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Implemented the Object Manager Interface. Using the interface, Tabbed Kwhiteboard is also implemented.
> GetManagedObjects method of the interface is not implemented yet, and the interface added signal is also having a parameter of QString only.
> 
> 
> Diffs
> -----
> 
>   kwhiteboard/CMakeLists.txt 3bbea3c 
>   kwhiteboard/kwhiteboard.h 43b572a 
>   kwhiteboard/kwhiteboard.cpp deb7129 
>   kwhiteboard/kwhiteboardwidget.h 431ccf2 
>   kwhiteboard/kwhiteboardwidget.cpp ce1b2a9 
>   kwhiteboard/objectManager.h PRE-CREATION 
>   kwhiteboard/objectManager.cpp PRE-CREATION 
>   kwhiteboard/org.freedesktop.DBus.ObjectManager.xml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106089/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Puneet Goyal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120820/f0645bfc/attachment-0001.html>