Review Request: Implemented the ObjectManager Interface and tabbed kwhiteboard

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Mon Aug 20 07:28:15 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106089/#review17735
-----------------------------------------------------------


I don't want to review the other patch again, so please do another branch for this...
Also remove the auto-generated files, I don't want to review them as well.


kwhiteboard/objectManager.h
<http://git.reviewboard.kde.org/r/106089/#comment13904>

    20102?



kwhiteboard/objectManager.cpp
<http://git.reviewboard.kde.org/r/106089/#comment13905>

    ?


- Daniele Elmo Domenichelli


On Aug. 19, 2012, 6:18 p.m., Puneet Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106089/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2012, 6:18 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Implemented the Object Manager Interface. Using the interface, Tabbed Kwhiteboard is also implemented.
> GetManagedObjects method of the interface is not implemented yet, and the interface added signal is also having a parameter of QString only.
> 
> 
> Diffs
> -----
> 
>   kwhiteboard/CMakeLists.txt 4a86efc 
>   kwhiteboard/ObjectManagerAdaptor.h PRE-CREATION 
>   kwhiteboard/ObjectManagerAdaptor.cpp PRE-CREATION 
>   kwhiteboard/ObjectManagerInterface.h PRE-CREATION 
>   kwhiteboard/ObjectManagerInterface.cpp PRE-CREATION 
>   kwhiteboard/kwhiteboard-handler.cpp ade1218 
>   kwhiteboard/kwhiteboard.h 33361c6 
>   kwhiteboard/kwhiteboard.cpp c16fd04 
>   kwhiteboard/kwhiteboardwidget.h 431ccf2 
>   kwhiteboard/kwhiteboardwidget.cpp ce1b2a9 
>   kwhiteboard/main.cpp 4371285 
>   kwhiteboard/objectManager.h PRE-CREATION 
>   kwhiteboard/objectManager.cpp PRE-CREATION 
>   kwhiteboard/org.kde.DBus.ObjectManager.xml PRE-CREATION 
>   kwhiteboard/org.kde.DBus.Peer.xml PRE-CREATION 
>   kwhiteboard/peer.h PRE-CREATION 
>   kwhiteboard/peer.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106089/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Puneet Goyal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120820/34a14362/attachment.html>


More information about the KDE-Telepathy mailing list