Review Request: So master isn't frozen anymore...

David Edmundson kde at davidedmundson.co.uk
Sun Aug 19 12:22:45 UTC 2012 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106083/#review17703
-----------------------------------------------------------


You're missing the entire pipes-filter and some .desktop files.

Run "git status" check you've added everything. 


filters/bugzilla/CMakeLists.txt
<http://git.reviewboard.kde.org/r/106083/#comment13843>

    I assume this is copied and pasted from somewhere, if so where?
    
    I doubt any of the rest of this works on MacOS.



filters/bugzilla/bugzilla-filter.cpp
<http://git.reviewboard.kde.org/r/106083/#comment13848>

    This should be taken from the original URL.
    
    Otherwise if a bugzilla instance only supports HTTP this won't work.



filters/bugzilla/bugzilla-filter.cpp
<http://git.reviewboard.kde.org/r/106083/#comment13844>

    is that comment really helpful :P



filters/bugzilla/bugzilla-filter.cpp
<http://git.reviewboard.kde.org/r/106083/#comment13845>

    I think the [0] can cause a crash if the list is empty/result in badly formatted.
    
    



filters/bugzilla/bugzilla-filter.cpp
<http://git.reviewboard.kde.org/r/106083/#comment13846>

    I would add a if (!description.isEmpty)
    
    otherwise we risk showing a 
    
    http://bugs.kde.org/show_bugs?id=
    
    which is empty.



filters/highlight/highlight-filter.cpp
<http://git.reviewboard.kde.org/r/106083/#comment13851>

    Not used?



filters/highlight/highlight-filter.cpp
<http://git.reviewboard.kde.org/r/106083/#comment13852>

    Not used



filters/highlight/highlight-filter.cpp
<http://git.reviewboard.kde.org/r/106083/#comment13850>

    const &



filters/highlight/highlight-filter.cpp
<http://git.reviewboard.kde.org/r/106083/#comment13853>

    I'd like a config on this (not now) like Kopete.



filters/highlight/highlight-filter.cpp
<http://git.reviewboard.kde.org/r/106083/#comment13849>

    Adium Themes have a message class "mention"
    
    http://trac.adium.im/wiki/CreatingMessageStyles
    
    Our renkoo theme supports this.
    It's why I wanted the property set, I'll make the AdiumConentInfo (or whichever it is) set this if the message property is set.



filters/highlight/ktptextui_message_filter_highlight.desktop
<http://git.reviewboard.kde.org/r/106083/#comment13854>

    This is actually running on both incoming and messages you send. Something that needs to be fixed.



filters/pipes/pipes-config.h
<http://git.reviewboard.kde.org/r/106083/#comment13855>

    Is this taken from Kopete? 
    If so, update.



filters/pipes/pipes-config.h
<http://git.reviewboard.kde.org/r/106083/#comment13858>

    This class isn't added.



filters/pipes/pipes-config.cpp
<http://git.reviewboard.kde.org/r/106083/#comment13856>

    You're not actually doing anything with this.



filters/pipes/pipes-config.cpp
<http://git.reviewboard.kde.org/r/106083/#comment13857>

    This class isn't added.


- David Edmundson


On Aug. 19, 2012, 10:29 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106083/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2012, 10:29 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Right, so here's a big fat review containing many many things, including all the remaining plugins and a few tweaks to Message.
> 
> As per usual, all the code is in my scratch repo: http://quickgit.kde.org/index.php?p=clones%2Fktp-text-ui%2Ffernando%2Fgsoc.git&a=summary
> 
> Now, I'm going to take a well earned nap.
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt ee7c23d 
>   filters/bugzilla/CMakeLists.txt PRE-CREATION 
>   filters/bugzilla/bugzilla-filter.h PRE-CREATION 
>   filters/bugzilla/bugzilla-filter.cpp PRE-CREATION 
>   filters/bugzilla/ktptextui_message_filter_bugzilla.desktop PRE-CREATION 
>   filters/highlight/CMakeLists.txt PRE-CREATION 
>   filters/highlight/highlight-filter.h PRE-CREATION 
>   filters/highlight/highlight-filter.cpp PRE-CREATION 
>   filters/highlight/ktptextui_message_filter_highlight.desktop PRE-CREATION 
>   filters/latex/CMakeLists.txt PRE-CREATION 
>   filters/latex/ktp_message_filter_latex_converter.sh PRE-CREATION 
>   filters/latex/ktptextui_message_filter_latex.desktop PRE-CREATION 
>   filters/latex/latex-filter.h PRE-CREATION 
>   filters/latex/latex-filter.cpp PRE-CREATION 
>   filters/pipes/CMakeLists.txt PRE-CREATION 
>   filters/pipes/kcm_ktp_filter_config_pipes.desktop PRE-CREATION 
>   filters/pipes/ktptextui_message_filter_pipes.desktop PRE-CREATION 
>   filters/pipes/pipes-config.h PRE-CREATION 
>   filters/pipes/pipes-config.cpp PRE-CREATION 
>   filters/pipes/pipes-config.ui PRE-CREATION 
>   filters/pipes/pipes-delegate.h PRE-CREATION 
>   filters/pipes/pipes-delegate.cpp PRE-CREATION 
>   filters/pipes/pipes-filter.h PRE-CREATION 
>   filters/pipes/pipes-filter.cpp PRE-CREATION 
>   filters/pipes/pipes-model.h PRE-CREATION 
>   filters/pipes/pipes-model.cpp PRE-CREATION 
>   filters/pipes/pipes-prefs.h PRE-CREATION 
>   filters/pipes/pipes-prefs.cpp PRE-CREATION 
>   filters/pipes/pipes-prefstest.h PRE-CREATION 
>   filters/pipes/pipes-prefstest.cpp PRE-CREATION 
>   filters/substitution/CMakeLists.txt PRE-CREATION 
>   filters/substitution/kcm_ktp_filter_config_substitution.desktop PRE-CREATION 
>   filters/substitution/ktptextui_message_filter_substitution.desktop PRE-CREATION 
>   filters/substitution/substitution-config.h PRE-CREATION 
>   filters/substitution/substitution-config.cpp PRE-CREATION 
>   filters/substitution/substitution-config.ui PRE-CREATION 
>   filters/substitution/substitution-filter.h PRE-CREATION 
>   filters/substitution/substitution-filter.cpp PRE-CREATION 
>   filters/substitution/substitution-prefs.h PRE-CREATION 
>   filters/substitution/substitution-prefs.cpp PRE-CREATION 
>   filters/youtube/CMakeLists.txt PRE-CREATION 
>   filters/youtube/ktptextui_message_filter_youtube.desktop PRE-CREATION 
>   filters/youtube/youtube-filter.h PRE-CREATION 
>   filters/youtube/youtube-filter.cpp PRE-CREATION 
>   lib/abstract-message-filter.h 7b60d48 
>   lib/abstract-message-filter.cpp 2a3a897 
>   lib/message.h ef9530b 
>   lib/message.cpp 6db648e 
>   tests/message-processor-basic-tests.h 7dc99e4 
>   tests/message-processor-basic-tests.cpp 8546605 
> 
> Diff: http://git.reviewboard.kde.org/r/106083/diff/
> 
> 
> Testing
> -------
> 
> Wrote/passed/failed unit tests; talked to myself so much to the point I swear I have mild schizophrenia now. 
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120819/cca50405/attachment-0001.html>

More information about the KDE-Telepathy mailing list