Review Request: Reimplemented the Peer Interface, removed some unused code and added the status bar.

[Martin Klapetek]

> On Aug. 17, 2012, 9:32 p.m., Daniele Elmo Domenichelli wrote:
> > kwhiteboard/kwhiteboard.cpp, line 43
> > <http://git.reviewboard.kde.org/r/106037/diff/7/?file=78259#file78259line43>
> >
> >     1) this is not translated
> >     2) I don't like it, just leave it empty... or use "Latency ???"

"Calculating latency..." looks better than "Latency ???", so I'd suggest to just add "..." at the end and leave that.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106037/#review17623
-----------------------------------------------------------


On Aug. 18, 2012, 7 a.m., Puneet Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106037/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2012, 7 a.m.)
> 
> 
> Review request for Telepathy and Daniele Elmo Domenichelli.
> 
> 
> Description
> -------
> 
> Reimplemented the Peer Interface, removed some unused code and added the status bar.
> 
> 
> Diffs
> -----
> 
>   kwhiteboard/CMakeLists.txt 4a86efc 
>   kwhiteboard/kwhiteboard-handler.cpp ade1218 
>   kwhiteboard/kwhiteboard.h 33361c6 
>   kwhiteboard/kwhiteboard.cpp c16fd04 
>   kwhiteboard/main.cpp 4371285 
>   kwhiteboard/org.kde.DBus.Peer.xml PRE-CREATION 
>   kwhiteboard/peer.h PRE-CREATION 
>   kwhiteboard/peer.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106037/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Puneet Goyal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120818/90fdfa81/attachment-0001.html>