Review Request: Allow to start ktp-dialout-ui with a preset number

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106061/#review17646
-----------------------------------------------------------

Ship it!


It's fine, but note that there is a new i18n'ed string there and we are in string freeze afaik.

- George Kiagiadakis


On Aug. 17, 2012, 2:35 p.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106061/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2012, 2:35 p.m.)
> 
> 
> Review request for Telepathy and George Kiagiadakis.
> 
> 
> Description
> -------
> 
> Allow to start ktp-dialout-ui with a preset number
> 
> This allows to start it from Kontact by setting Settings > Configure Kontact... > Contacts > Contact Actions > Dial Phone Number
> 
> "External Application"
> Command "/usr/bin/ktp-dialout-ui %n"
> 
> 
> Diffs
> -----
> 
>   src/dialout/dialout-widget.h 9ad86c195f3a46b94b9502285255dcc17ce248f2 
>   src/dialout/dialout-widget.cpp 39ec176307ba1a8f72c4dc5f50f04dc6c00ed1c9 
>   src/dialout/main-window.h 2b1f5c1f56649db882a6ea75b67e733f0c9ff880 
>   src/dialout/main-window.cpp 2adae108862ec01a9218dad8639f63ac2b402636 
>   src/dialout/main.cpp 1a2db55e1ca680fbf5b3e29328533b1176c876d6 
> 
> Diff: http://git.reviewboard.kde.org/r/106061/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120818/075608f3/attachment.html>