Review Request: Reimplemented the Peer Interface, removed some unused code and added the status bar.

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106037/#review17577
-----------------------------------------------------------



kwhiteboard/kwhiteboard.h
<http://git.reviewboard.kde.org/r/106037/#comment13779>

    #include <QtGui/Qlabel>
    http://techbase.kde.org/Policies/Kdelibs_Coding_Style#Qt_Includes



kwhiteboard/kwhiteboard.h
<http://git.reviewboard.kde.org/r/106037/#comment13780>

    QtDBus/...



kwhiteboard/kwhiteboard.h
<http://git.reviewboard.kde.org/r/106037/#comment13778>

    m_



kwhiteboard/kwhiteboard.cpp
<http://git.reviewboard.kde.org/r/106037/#comment13781>

    same



kwhiteboard/kwhiteboard.cpp
<http://git.reviewboard.kde.org/r/106037/#comment13782>

    same



kwhiteboard/kwhiteboard.cpp
<http://git.reviewboard.kde.org/r/106037/#comment13784>

    You have at least to check if the ping call succeded before setting the label.
    Moreover you should pay attention to what would happen if you start the timer another time before the first call is finished.
    
    



kwhiteboard/kwhiteboard.cpp
<http://git.reviewboard.kde.org/r/106037/#comment13785>

    leaking one QTime every 10 seconds.



kwhiteboard/kwhiteboard.cpp
<http://git.reviewboard.kde.org/r/106037/#comment13786>

    You should check here if there is another call running, and eventually skip calling Ping again.


- Daniele Elmo Domenichelli


On Aug. 16, 2012, 5:32 p.m., Puneet Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106037/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2012, 5:32 p.m.)
> 
> 
> Review request for Telepathy and Daniele Elmo Domenichelli.
> 
> 
> Description
> -------
> 
> Reimplemented the Peer Interface, removed some unused code and added the status bar.
> 
> 
> Diffs
> -----
> 
>   kwhiteboard/CMakeLists.txt 4a86efc 
>   kwhiteboard/kwhiteboard-handler.cpp ade1218 
>   kwhiteboard/kwhiteboard.h 33361c6 
>   kwhiteboard/kwhiteboard.cpp c16fd04 
>   kwhiteboard/main.cpp 4371285 
>   kwhiteboard/org.kde.DBus.Peer.xml PRE-CREATION 
>   kwhiteboard/peer.h PRE-CREATION 
>   kwhiteboard/peer.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106037/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Puneet Goyal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120817/bff0290e/attachment-0001.html>