Review Request: Reimplemented the Peer Interface, removed some unused code and added the status bar.

Thu Aug 16 15:46:42 UTC 2012

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106037/#review17545
-----------------------------------------------------------


kwhiteboard/kwhiteboard.h
<http://git.reviewboard.kde.org/r/106037/#comment13753>

    The style for Qt includes used here is: #include <QtDBus/QDBusConnection>
    
    That means that you should do
    #include <QtGui/QLabel>


kwhiteboard/kwhiteboard.cpp
<http://git.reviewboard.kde.org/r/106037/#comment13752>

    NO! In the timerEvent method you have to start the ping, and connect a QDBusPendingCallWatcher signal Finished to a slot where you read the latency and display it in the status bar


kwhiteboard/kwhiteboardwidget.cpp
<http://git.reviewboard.kde.org/r/106037/#comment13749>

    WHY?


kwhiteboard/kwhiteboardwidget.cpp
<http://git.reviewboard.kde.org/r/106037/#comment13750>

    WHY


kwhiteboard/kwhiteboardwidget.cpp
<http://git.reviewboard.kde.org/r/106037/#comment13751>

    WHY!!!!!!


- Daniele Elmo Domenichelli


On Aug. 16, 2012, 3:31 p.m., Puneet Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106037/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2012, 3:31 p.m.)
> 
> 
> Review request for Telepathy and Daniele Elmo Domenichelli.
> 
> 
> Description
> -------
> 
> Reimplemented the Peer Interface, removed some unused code and added the status bar.
> 
> 
> Diffs
> -----
> 
>   kwhiteboard/CMakeLists.txt 4a86efc94cd872224a147e24f005f2d3090d6f1a 
>   kwhiteboard/kwhiteboard-handler.cpp ade1218d950689e7aa809bac92850d6e01424e2e 
>   kwhiteboard/kwhiteboard.h 33361c620369eac011411211a2662e8a2855e448 
>   kwhiteboard/kwhiteboard.cpp c16fd04d185046cf6e413a7b59b958bf45748d5a 
>   kwhiteboard/kwhiteboardwidget.cpp ce1b2a9bcb6b67a1f8ab4dd2d2184b9ac25e927d 
>   kwhiteboard/main.cpp 4371285a3c7fbfff0b53f84d9a909408c1037337 
>   kwhiteboard/org.kde.DBus.Peer.xml PRE-CREATION 
>   kwhiteboard/peer.h PRE-CREATION 
>   kwhiteboard/peer.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106037/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Puneet Goyal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120816/4a06a09b/attachment-0001.html>