Review Request: Reimplemented the Peer Interface, removed some unused code and added the status bar.

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106037/#review17530
-----------------------------------------------------------



kwhiteboard/kwhiteboard-handler.cpp
<http://git.reviewboard.kde.org/r/106037/#comment13729>

    As I told you, please merge the onGotTubeDBusConnection into the constructor



kwhiteboard/kwhiteboard.h
<http://git.reviewboard.kde.org/r/106037/#comment13722>

    You are not using the whole QtGui



kwhiteboard/kwhiteboard.cpp
<http://git.reviewboard.kde.org/r/106037/#comment13731>

    Are you using this?



kwhiteboard/kwhiteboard.cpp
<http://git.reviewboard.kde.org/r/106037/#comment13725>

    QTime?



kwhiteboard/kwhiteboard.cpp
<http://git.reviewboard.kde.org/r/106037/#comment13727>

    Please split this method and make the call asyncronous



kwhiteboard/kwhiteboard.cpp
<http://git.reviewboard.kde.org/r/106037/#comment13726>

    In this way you keep creating timers and keep connecting your widget to new timers.
    
    Either use QObject::startTimer()[1] or Start and connect the timer in the constructor
    
    [1]http://qt-project.org/doc/qt-4.8/qobject.html#startTimer



kwhiteboard/kwhiteboardwidget.cpp
<http://git.reviewboard.kde.org/r/106037/#comment13723>

    Can you please check the diff before submitting it?


- Daniele Elmo Domenichelli


On Aug. 16, 2012, 1 p.m., Puneet Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106037/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2012, 1 p.m.)
> 
> 
> Review request for Telepathy and Daniele Elmo Domenichelli.
> 
> 
> Description
> -------
> 
> Reimplemented the Peer Interface, removed some unused code and added the status bar.
> 
> 
> Diffs
> -----
> 
>   kwhiteboard/CMakeLists.txt 4a86efc94cd872224a147e24f005f2d3090d6f1a 
>   kwhiteboard/kwhiteboard-handler.cpp ade1218d950689e7aa809bac92850d6e01424e2e 
>   kwhiteboard/kwhiteboard.h 33361c620369eac011411211a2662e8a2855e448 
>   kwhiteboard/kwhiteboard.cpp c16fd04d185046cf6e413a7b59b958bf45748d5a 
>   kwhiteboard/kwhiteboardwidget.cpp ce1b2a9bcb6b67a1f8ab4dd2d2184b9ac25e927d 
>   kwhiteboard/main.cpp 4371285a3c7fbfff0b53f84d9a909408c1037337 
>   kwhiteboard/org.kde.DBus.Peer.xml PRE-CREATION 
>   kwhiteboard/peer.h PRE-CREATION 
>   kwhiteboard/peer.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106037/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Puneet Goyal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120816/e122acb6/attachment-0001.html>