Review Request: (1/2) Improve groups expansion in contact list

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106024/#review17433
-----------------------------------------------------------


This review has been submitted with commit 1bb7f6f72e84a827ce5c00b9148e5a929412e821 by Martin Klapetek to branch master.

- Commit Hook


On Aug. 15, 2012, 8:20 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106024/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2012, 8:20 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> If the contact has no groups, it is placed into "Ungrouped" group. This is done when the group name is empty. However the group still needs some id in the model to properly handle the expanded/collapsed state, ie. you can't save an empty string into config file. The AccountsModel::IdRole & GroupsModel::GroupNameRole is not used anywhere in the UI, so the user won't see this. And returning this on the model level makes sure this group is actually not created on the server.
> 
> 
> Diffs
> -----
> 
>   KTp/Models/groups-model-item.cpp c85ffbf 
> 
> Diff: http://git.reviewboard.kde.org/r/106024/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120815/2ab4d912/attachment.html>