Review Request: (1/2) Improve groups expansion in contact list

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106024/#review17419
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Aug. 14, 2012, 10:13 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106024/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2012, 10:13 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> If the contact has no groups, it is placed into "Ungrouped" group. This is done when the group name is empty. However the group still needs some id in the model to properly handle the expanded/collapsed state, ie. you can't save an empty string into config file. The AccountsModel::IdRole & GroupsModel::GroupNameRole is not used anywhere in the UI, so the user won't see this. And returning this on the model level makes sure this group is actually not created on the server.
> 
> 
> Diffs
> -----
> 
>   KTp/Models/groups-model-item.cpp c85ffbf 
> 
> Diff: http://git.reviewboard.kde.org/r/106024/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120814/5665a729/attachment.html>