Review Request: Show ToolButton in compact respentation pressed whilst the popup is open
Aleix Pol Gonzalez
aleixpol at gmail.com
Mon Aug 13 22:38:04 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106004/#review17344
-----------------------------------------------------------
Ship it!
I like it.
In the future, I think we should aim for looking like the Icon-only tasks plasmoid.
plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegate.qml
<http://git.reviewboard.kde.org/r/106004/#comment13530>
remove the empty lines?
- Aleix Pol Gonzalez
On Aug. 13, 2012, 7:35 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106004/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2012, 7:35 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Show ToolButton in compact respentation pressed whilst the popup is open
>
> Provides a much clearer way to see which contact's chat is open.
>
>
> Diffs
> -----
>
> plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegate.qml c73d2d428dad9f8f122a48e28018fe15298af2a7
> plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml 12418947d477c388edd3856360d28af2ed170d37
>
> Diff: http://git.reviewboard.kde.org/r/106004/diff/
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> After
> http://git.reviewboard.kde.org/r/106004/s/674/
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120813/a8670171/attachment-0001.html>
More information about the KDE-Telepathy
mailing list