Review Request: Small plasmoid fixes

[David Edmundson]

> On Aug. 13, 2012, 1:55 p.m., Aleix Pol Gonzalez wrote:
> > plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml, line 36
> > <http://git.reviewboard.kde.org/r/106001/diff/1/?file=77338#file77338line36>
> >
> >     why?

have you ever wanted to scroll when it's in the compact mode? We resize to make everything fit anyway.


> On Aug. 13, 2012, 1:55 p.m., Aleix Pol Gonzalez wrote:
> > plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml, line 42
> > <http://git.reviewboard.kde.org/r/106001/diff/1/?file=77338#file77338line42>
> >
> >     I think it's useful to know what's the currently opened conversation... no?

but you can't see (or at least in my case) see the highlight. Also having a highlight of a smiley face is weird.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106001/#review17310
-----------------------------------------------------------


On Aug. 13, 2012, 1:36 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106001/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2012, 1:36 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Use attached properties to get model data
> Don't allow the interactive scrolling on the plasmoid base
> Elide contact alias properly
> Remove pointless highlight that you can't see anyway
> 
> 
> Diffs
> -----
> 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml 6ba6005a6a9a30d6e2fe103929168bce91ab947b 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegate.qml 6767580a0d127e5ad0c4a483c1404214d32fb095 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml ffdd42ea5ca5e363170d0f4f27248e786d3a5a52 
> 
> Diff: http://git.reviewboard.kde.org/r/106001/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120813/cba21bc5/attachment.html>