Review Request: QuickChat Plasmoid: Force vertical layout if it's in a left or right panel

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105998/#review17306
-----------------------------------------------------------

Ship it!


I think there's a better way to determine panel orientation. 


plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/105998/#comment13482>

    I would suggest using 
    
    plasmoid.formFactor === vertical
    


- David Edmundson


On Aug. 13, 2012, 12:50 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105998/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2012, 12:50 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> With the current implementation, the plasmoid would decide if it has to use a vertical or horizontal layout depending on the plasmoid size.
> 
> This doesn't really work for panels, so let's make it a special case and force vertical orientation there.
> 
> 
> Diffs
> -----
> 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml ffdd42e 
> 
> Diff: http://git.reviewboard.kde.org/r/105998/diff/
> 
> 
> Testing
> -------
> 
> plasmoidviewer -l <right/left/top/bottom/nothing> works fine.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120813/a340dc01/attachment-0001.html>