Review Request: Makes the dialogs to appear again
David Edmundson
kde at davidedmundson.co.uk
Mon Aug 13 13:20:46 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105997/#review17305
-----------------------------------------------------------
Ship it!
Ship It!
plasmoid/declarative-plugin/hidewindowcomponent.cpp
<http://git.reviewboard.kde.org/r/105997/#comment13481>
Explain why we're doing this in a comment - ideally also add a link to a bug in plasma about exposing this property.
- David Edmundson
On Aug. 13, 2012, 1:16 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105997/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2012, 1:16 p.m.)
>
>
> Review request for Telepathy and David Edmundson.
>
>
> Description
> -------
>
> Use Qt.FramelessWindowHint on the windowFlags instead of Qt.Tool
>
> It's the same that PopupApplet uses...
>
>
> This addresses bug 302440.
> http://bugs.kde.org/show_bug.cgi?id=302440
>
>
> Diffs
> -----
>
> plasmoid/declarative-plugin/CMakeLists.txt 413692c
> plasmoid/declarative-plugin/hidewindowcomponent.h PRE-CREATION
> plasmoid/declarative-plugin/hidewindowcomponent.cpp PRE-CREATION
> plasmoid/declarative-plugin/qml-plugins.cpp c788c4e
> plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml ffdd42e
>
> Diff: http://git.reviewboard.kde.org/r/105997/diff/
>
>
> Testing
> -------
>
> Chatted with myself from a panel (not plasmoidviewer like I used to)
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120813/f79cd0ed/attachment.html>
More information about the KDE-Telepathy
mailing list