Review Request: Run backlog messages through the message processor

[David Edmundson]

> On Aug. 9, 2012, 6:55 p.m., Dan Vratil wrote:
> > lib/message-processor.cpp, lines 68-71
> > <http://git.reviewboard.kde.org/r/105943/diff/1/?file=76726#file76726line68>
> >
> >     Do we still need this method when it does exactly the same as processIncommingMessage() ?

no, but the bug is that it does the same thing as processIncomingMessage!
The logic was that you (probably) don't want to see video previews of things you've sent etc.

However, this hasn't made it's way into the rest of the code yet.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105943/#review17166
-----------------------------------------------------------


On Aug. 9, 2012, 10:51 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105943/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2012, 10:51 a.m.)
> 
> 
> Review request for Telepathy and Lasath Fernando.
> 
> 
> Description
> -------
> 
> Allow KTp::Message to be constructed from both Tp::Message and Tpl::Message, this allows backlog to go through the message processor.
> 
> This allows links and emoticons in the loaded backlog. It also will allow (with a separate 1 line patch) all this in the log-viewer.
> 
> 
> Diffs
> -----
> 
>   lib/message.cpp 3f22a17 
>   lib/message-processor.h 2b070bd 
>   lib/message-processor.cpp 09ab98e 
>   lib/message.h df183f8 
>   CMakeLists.txt a5a3826 
>   config/messages-config.cpp fd79b56 
>   lib/CMakeLists.txt aed670a 
>   lib/logmanager.cpp d4736d4 
> 
> Diff: http://git.reviewboard.kde.org/r/105943/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120809/c89b5dfb/attachment.html>