Review Request: Async Wallet in Account Manager

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105926/#review17132
-----------------------------------------------------------

Ship it!


Patch looks good, I would like to have the wallet utils in common-internals though...


src/wallet-utils.h
<http://git.reviewboard.kde.org/r/105926/#comment13402>

    Copyright is missing



src/wallet-utils.cpp
<http://git.reviewboard.kde.org/r/105926/#comment13403>

    Copyright is missing


- Daniele Elmo Domenichelli


On Aug. 8, 2012, 1:40 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105926/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2012, 1:40 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Async wallet usage. Updated to compile with latest common-internals
> 
> Also tidied up some rather mental/legacy code when removing accounts from the model. Hopefully fixes the crashes when removing accounts that we've been seeing.
> 
> The wallet stuff is still a bit messy, the API wasn't really suitable for async usage. When I ported it I tried to do it in the least destructive way which in retrospect turned out to be a really bad idea.
> 
> I've decided how I'm going to fix it all in the future (based on the WalletUtil class here) but for getting password data too. But I don't want to redo that all now.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ee82fd0 
>   src/account-item.h aba7e0e 
>   src/account-item.cpp 0cac63f 
>   src/accounts-list-model.h 1791e67 
>   src/accounts-list-model.cpp c7837bc 
>   src/add-account-assistant.cpp 880b423 
>   src/edit-account-dialog.h 6fdf98d 
>   src/edit-account-dialog.cpp 91eeccf 
>   src/kcm-telepathy-accounts.cpp ca37ad1 
>   src/wallet-utils.h PRE-CREATION 
>   src/wallet-utils.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105926/diff/
> 
> 
> Testing
> -------
> 
> Created an account, edited it, removed it.
> No problems. Would appreciate more testing once merged though.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120809/a7cc0128/attachment-0001.html>