Review Request: AddAccountAssistant Fixes

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105911/#review17036
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Aug. 7, 2012, 1:37 p.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105911/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2012, 1:37 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Use .ui file to create the buttons in SimpleProfileSelectWidget, fix some resizing bugs, do not show help button in AddAccountAssistant and some cleaning.
> 
> 
> This addresses bugs 292690 and 294010.
>     http://bugs.kde.org/show_bug.cgi?id=292690
>     http://bugs.kde.org/show_bug.cgi?id=294010
> 
> 
> Diffs
> -----
> 
>   src/KCMTelepathyAccounts/simple-profile-select-widget.cpp 174488ed98e15464c7e0932ac736d2d68cdd60f3 
>   src/KCMTelepathyAccounts/simple-profile-select-widget.ui 5d36e39a98fc32ae81fca7d56b911ead70f09f8b 
>   src/add-account-assistant.cpp 880b4235f7ebc6348102819158e6d0485e9e432e 
> 
> Diff: http://git.reviewboard.kde.org/r/105911/diff/
> 
> 
> Testing
> -------
> 
> AddAccountAssistant resizes properly
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120807/9b710ff5/attachment.html>