Review Request: [logviewer] Add links to previous and next conversations to empty logs too

David Edmundson kde at davidedmundson.co.uk
Tue Aug 7 08:48:34 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105762/#review17022
-----------------------------------------------------------

Ship it!


Looks awesome.


logviewer/conversation-date-picker.cpp
<http://git.reviewboard.kde.org/r/105762/#comment13367>

    .constBegin()


- David Edmundson


On Aug. 6, 2012, 7:38 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105762/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2012, 7:38 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add "Previous conversation" and "Next conversation" links to logview even when the chat log for selected date is empty, so that it's easy to jump to nearest date with some non-empty chat log.
> 
> 
> This addresses bug 304137.
>     http://bugs.kde.org/show_bug.cgi?id=304137
> 
> 
> Diffs
> -----
> 
>   logviewer/conversation-date-picker.cpp c6bbf2e 
>   logviewer/log-viewer.cpp 5866cdb 
> 
> Diff: http://git.reviewboard.kde.org/r/105762/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120807/7fed7154/attachment.html>


More information about the KDE-Telepathy mailing list