Review Request: Port LatexPlugin to Filter

Lasath Fernando kde at lasath.org
Mon Aug 6 12:52:02 UTC 2012



> On Aug. 6, 2012, 9:53 a.m., David Edmundson wrote:
> > tests/message-processor-basic-tests.cpp, line 182
> > <http://git.reviewboard.kde.org/r/105887/diff/4/?file=76295#file76295line182>
> >
> >     Replace this with something less derpy.
> >     
> >     Here, have the DCT used in libJPEG.
> >     $$F_{uv} = \frac{1}{4}C_uC_v\sum_{x=0}^{7} \sum_{y=0}^{7} f_{xy} \ast \cos\left(\frac{(2x+1)u\pi}{16}\right) \cos\left(\frac{(2y+1)v\pi}{16}\right)$$
> >

That test was there mostly so I could test that it was doing _something_. (I assumed that kopete's latex plugin produced the correct output). 

I'll fix that test sometime later.
(Maybe that could stay as a minor task in BKO).


- Lasath


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105887/#review16956
-----------------------------------------------------------


On Aug. 6, 2012, 12:50 p.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105887/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2012, 12:50 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This is pretty much the latex plugin from Kopete.
> If any incoming text is in latex surrounded by $$, it renders it in the chat window.
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt ca5ec1e 
>   filters/latex/CMakeLists.txt PRE-CREATION 
>   filters/latex/ktp_message_filter_latex_converter.sh PRE-CREATION 
>   filters/latex/ktptextui_message_filter_latex.desktop PRE-CREATION 
>   filters/latex/latex-filter.h PRE-CREATION 
>   filters/latex/latex-filter.cpp PRE-CREATION 
>   tests/message-processor-basic-tests.h 7dc99e4 
>   tests/message-processor-basic-tests.cpp 8546605 
> 
> Diff: http://git.reviewboard.kde.org/r/105887/diff/
> 
> 
> Testing
> -------
> 
> David sent me a formula that rendered nicely in my chat window.
> 
> Note to future self: update unit test so it matches a regex (to account for random temp file).
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120806/366de869/attachment.html>


More information about the KDE-Telepathy mailing list