Review Request: Port LatexPlugin to Filter

[David Edmundson]

> On Aug. 6, 2012, 12:28 a.m., David Edmundson wrote:
> > filters/latex/latex-filter.cpp, line 124
> > <http://git.reviewboard.kde.org/r/105887/diff/2/?file=76258#file76258line124>
> >
> >     for () {
> >     
> >     }
> 
> Lasath Fernando wrote:
>     huh?

brace starts after the for line, not on the next line.


> On Aug. 6, 2012, 12:28 a.m., David Edmundson wrote:
> > filters/latex/latex-filter.cpp, line 75
> > <http://git.reviewboard.kde.org/r/105887/diff/2/?file=76258#file76258line75>
> >
> >     Don't have commented out code
> >     
> >     
> >     Or at least explain why it's commented out
> 
> Lasath Fernando wrote:
>     To be perfectly honest, I have no idea.

I got that impression :P. Remove it.


> On Aug. 6, 2012, 12:28 a.m., David Edmundson wrote:
> > filters/latex/latex-filter.cpp, line 101
> > <http://git.reviewboard.kde.org/r/105887/diff/2/?file=76258#file76258line101>
> >
> >     no-one ever sets this.
> 
> Lasath Fernando wrote:
>     I was hoping you (or someone else here) might recognize what it was for...

it's #defined to 0 at the top of latexplugin.cpp

So this code will never ever run. Remove it.


> On Aug. 6, 2012, 12:28 a.m., David Edmundson wrote:
> > filters/latex/latex-filter.cpp, line 176
> > <http://git.reviewboard.kde.org/r/105887/diff/2/?file=76258#file76258line176>
> >
> >     This doesn't actually delete the temporary file.. you're just deleting the pointer to it.
> 
> Lasath Fernando wrote:
>     uh oh.. did Kopete spam temp files anywhere or did/does some KDE magic take care of it?

I'm wrong. Though given you clearly didn't know, I was right to question it.

QTemporaryFile::~QTemporaryFile ()
Destroys the temporary file object, the file is automatically closed if necessary and if in auto remove mode it will automatically delete the file.

(auto-remove is on by default)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105887/#review16924
-----------------------------------------------------------


On Aug. 6, 2012, 12:36 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105887/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2012, 12:36 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This is pretty much the latex plugin from Kopete.
> If any incoming text is in latex surrounded by $$, it renders it in the chat window.
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt ca5ec1e 
>   filters/latex/CMakeLists.txt PRE-CREATION 
>   filters/latex/ktptextui_message_filter_latex.desktop PRE-CREATION 
>   filters/latex/latex-filter.h PRE-CREATION 
>   filters/latex/latex-filter.cpp PRE-CREATION 
>   tests/message-processor-basic-tests.h 7dc99e4 
>   tests/message-processor-basic-tests.cpp 8546605 
> 
> Diff: http://git.reviewboard.kde.org/r/105887/diff/
> 
> 
> Testing
> -------
> 
> David sent me a formula that rendered nicely in my chat window.
> 
> Note to future self: update unit test so it matches a regex (to account for random temp file).
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120806/2017ee7c/attachment.html>