Review Request: Port LatexPlugin to Filter

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105887/#review16924
-----------------------------------------------------------



filters/latex/latex-filter.cpp
<http://git.reviewboard.kde.org/r/105887/#comment13287>

    I think this is going to cause a problem!



filters/latex/latex-filter.cpp
<http://git.reviewboard.kde.org/r/105887/#comment13288>

    don't have commented out code.



filters/latex/latex-filter.cpp
<http://git.reviewboard.kde.org/r/105887/#comment13289>

    {}



filters/latex/latex-filter.cpp
<http://git.reviewboard.kde.org/r/105887/#comment13290>

    Don't have commented out code
    
    
    Or at least explain why it's commented out



filters/latex/latex-filter.cpp
<http://git.reviewboard.kde.org/r/105887/#comment13292>

    no-one ever sets this.



filters/latex/latex-filter.cpp
<http://git.reviewboard.kde.org/r/105887/#comment13291>

    if () {
    
    }



filters/latex/latex-filter.cpp
<http://git.reviewboard.kde.org/r/105887/#comment13293>

    {}



filters/latex/latex-filter.cpp
<http://git.reviewboard.kde.org/r/105887/#comment13294>

    for () {
    
    }



filters/latex/latex-filter.cpp
<http://git.reviewboard.kde.org/r/105887/#comment13295>

    commented out code.



filters/latex/latex-filter.cpp
<http://git.reviewboard.kde.org/r/105887/#comment13296>

    This doesn't actually delete the temporary file.. you're just deleting the pointer to it.


- David Edmundson


On Aug. 6, 2012, 12:17 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105887/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2012, 12:17 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This is pretty much the latex plugin from Kopete.
> If any incoming text is in latex surrounded by $$, it renders it in the chat window.
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt ca5ec1e 
>   filters/latex/CMakeLists.txt PRE-CREATION 
>   filters/latex/ktptextui_message_filter_latex.desktop PRE-CREATION 
>   filters/latex/latex-filter.h PRE-CREATION 
>   filters/latex/latex-filter.cpp PRE-CREATION 
>   tests/message-processor-basic-tests.h 7dc99e4 
>   tests/message-processor-basic-tests.cpp 8546605 
> 
> Diff: http://git.reviewboard.kde.org/r/105887/diff/
> 
> 
> Testing
> -------
> 
> David sent me a formula that rendered nicely in my chat window.
> 
> Note to future self: update unit test so it matches a regex (to account for random temp file).
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120806/d1469744/attachment-0001.html>